Skip to content

Don't repeatedly find_package(GTest) while running CMake #9146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

Don't repeatedly find_package(GTest) while running CMake #9146

merged 1 commit into from
Mar 11, 2025

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 11, 2025

This seems to improve cmake times by 6-10 seconds on my machine.

@swolchok
Update
7f1ea55 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 11, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9146

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 7f1ea55 with merge base d71f54a (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 11, 2025
swolchok added a commit that referenced this pull request Mar 11, 2025
@swolchok
Don't repeatedly find_package(GTest) while running CMake
06244d9 
This seems to improve cmake times by 6-10 seconds on my machine.

ghstack-source-id: 530268d
ghstack-comment-id: 2715089715
Pull Request resolved: #9146
@swolchok swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Mar 11, 2025
@swolchok
Copy link
Contributor Author

swolchok commented Mar 11, 2025

test failures are pretty clearly flakes, merging

@swolchok swolchok merged commit deb3cd1 into main Mar 11, 2025
48 of 52 checks passed
@swolchok swolchok deleted the gh/swolchok/345/head branch March 11, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GregoryComer GregoryComer Awaiting requested review from GregoryComer

@kirklandsign kirklandsign Awaiting requested review from kirklandsign

1 more reviewer

@mcr229 mcr229 mcr229 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok @mcr229 @facebook-github-bot