Add null runtime check for XNNExecutor::prepare_args #9265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9265
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2d2928b with merge base 2bee76e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@pytorchbot label "topic: not user facing" |
|
Can you write a test to exercise this code path? |
GregoryComer
approved these changes
Mar 18, 2025
|
I'm going to merge this as is, since it's a small change, and existing CI should be sufficient. |
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
### Summary Fixes pytorch#9131 In the event that an XNNPACK-delegated model is freed right when inference happens, `XNNExecutor::prepare_args` can crash accessing the runtime. Hence we need to check for null runtime for it, similar to what we are already doing for `XNNExecutor::forward`. ### Test plan Pass all CI/CD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9131
In the event that an XNNPACK-delegated model is freed right when inference happens,
XNNExecutor::prepare_argscan crash accessing the runtime. Hence we need to check for null runtime for it, similar to what we are already doing forXNNExecutor::forward.Test plan
Pass all CI/CD.