Arm backend: use dbg_fail when node visitors raise exceptions #9268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9268
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 62b7b40 with merge base 8c32da7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
facebook-github-bot
added
the
CLA Signed
Adds a try-expect around the node_visitor call to be able to call dbg_fail() when an error/exception is raised. Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: I3b633e1ff255fa5b3a5257016acfe2e9dc03b033
Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: Id7f44c539682a55e06564c7b3294988c122c00b3
oscarandersson8218
force-pushed
the
dbg_fail
branch
from
4dab55e to
c43bfdb
Compare
zingo
approved these changes
Mar 18, 2025
Contributor
|
This broke our internal tests and we need to revert it first. Could you please re-submit the PR, and wait for us to import and run internal CI, and paste the error message? |
larryliu0820
added a commit
that referenced
this pull request
Mar 18, 2025
Collaborator
Author
|
@larryliu0820 I've re-submitted the PR in #9391 |
oscarandersson8218
added a commit
to oscarandersson8218/executorch
that referenced
this pull request
Mar 21, 2025
…h#9268) Adds a try-expect around the node_visitor call to be able to call dbg_fail() when an error/exception is raised. Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
oscarandersson8218
pushed a commit
to oscarandersson8218/executorch
that referenced
this pull request
Mar 21, 2025
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
…h#9268) Adds a try-expect around the node_visitor call to be able to call dbg_fail() when an error/exception is raised. Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a try-expect around the node_visitor call to be able to call dbg_fail() when an error/exception is raised.
cc @digantdesai @freddan80 @per @zingo