Create the foundation for testing CoreML export for wheels #9381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9381
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Pending, 1 Unrelated FailureAs of commit 51e3e3a with merge base 01a22b6 ( NEW FAILURE - The following job has failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jathu
force-pushed
the
jathu/wheel-test-others
branch
from
9a927f3 to
fee3327
Compare
jathu
force-pushed
the
jathu/wheel-test-others
branch
from
fee3327 to
22fd470
Compare
jathu
force-pushed
the
jathu/wheel-test-others
branch
2 times, most recently
from
8accd11 to
e2fadc9
Compare
jathu
force-pushed
the
jathu/wheel-test-others
branch
from
e2fadc9 to
f81864e
Compare
jathu
force-pushed
the
jathu/wheel-test-others
branch
5 times, most recently
from
7aa10d0 to
72f336a
Compare
cccclai
reviewed
Mar 19, 2025
jathu
force-pushed
the
jathu/wheel-test-others
branch
2 times, most recently
from
a0248a0 to
caae5ef
Compare
jathu
force-pushed
the
jathu/wheel-test-others
branch
from
caae5ef to
51e3e3a
Compare
larryliu0820
approved these changes
Mar 19, 2025
oscarandersson8218
pushed a commit
to oscarandersson8218/executorch
that referenced
this pull request
Mar 21, 2025
) ### Summary As part of pytorch#9019, this will allow us to test CoreML support for wheels. #### Why are we only selectively running the executor test? Our `macos-*-stable` runners do not have xcode, which is required to build and run these tests. Only GitHub's `macos-*-xlarge` runners have xcode. We currently run these CoreML tests on [trunk](https://github.com/pytorch/executorch/blob/7c6d2f332861907391450974a481b6d8e04732ed/.github/workflows/trunk.yml#L444-L477), which would be way too expensive to use GitHub's runner given the frequency. So let's limit the runner tests to just the wheel jobs. I will work with Test Infra to get Xcode into our runners. ### Test plan * Wheel tests shouldn't change * Test locally ```bash $ GITHUB_WORKSPACE=$(dirname $(pwd)) REPOSITORY=$(basename $(pwd)) python .ci/scripts/wheel/test_macos.py ```
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
) ### Summary As part of pytorch#9019, this will allow us to test CoreML support for wheels. #### Why are we only selectively running the executor test? Our `macos-*-stable` runners do not have xcode, which is required to build and run these tests. Only GitHub's `macos-*-xlarge` runners have xcode. We currently run these CoreML tests on [trunk](https://github.com/pytorch/executorch/blob/7c6d2f332861907391450974a481b6d8e04732ed/.github/workflows/trunk.yml#L444-L477), which would be way too expensive to use GitHub's runner given the frequency. So let's limit the runner tests to just the wheel jobs. I will work with Test Infra to get Xcode into our runners. ### Test plan * Wheel tests shouldn't change * Test locally ```bash $ GITHUB_WORKSPACE=$(dirname $(pwd)) REPOSITORY=$(basename $(pwd)) python .ci/scripts/wheel/test_macos.py ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of #9019, this will allow us to test CoreML support for wheels.
Why are we only selectively running the executor test?
Our
macos-*-stablerunners do not have xcode, which is required to build and run these tests. Only GitHub'smacos-*-xlargerunners have xcode. We currently run these CoreML tests on trunk, which would be way too expensive to use GitHub's runner given the frequency. So let's limit the runner tests to just the wheel jobs. I will work with Test Infra to get Xcode into our runners.Test plan