Skip to content

Utility helper to extract a value from NSNumber. #9595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Utility helper to extract a value from NSNumber. #9595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions extension/apple/ExecuTorch/Internal/ExecuTorchUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@
#ifdef __cplusplus

#import <executorch/runtime/core/exec_aten/exec_aten.h>
#import <executorch/runtime/core/exec_aten/util/scalar_type_util.h>

namespace executorch::extension::utils {
using namespace aten;
using namespace runtime;

/**
* Deduces the scalar type for a given NSNumber based on its type encoding.
Expand Down Expand Up @@ -41,6 +43,56 @@ static inline ScalarType deduceScalarType(NSNumber *number) {
return ScalarType::Undefined;
}

/**
* Converts the value held in the NSNumber to the specified C++ type T.
*
* @tparam T The target C++ numeric type.
* @param number The NSNumber instance to extract the value from.
* @return The value converted to type T.
*/
template <typename T>
static inline T extractValue(NSNumber *number) {
ET_CHECK_MSG(!(isFloatingType(deduceScalarType(number)) &&
isIntegralType(CppTypeToScalarType<T>::value, true)),
"Cannot convert floating point to integral type");
T value;
if constexpr (std::is_same_v<T, uint8_t>) {
value = number.unsignedCharValue;
} else if constexpr (std::is_same_v<T, int8_t>) {
value = number.charValue;
} else if constexpr (std::is_same_v<T, int16_t>) {
value = number.shortValue;
} else if constexpr (std::is_same_v<T, int32_t>) {
value = number.intValue;
} else if constexpr (std::is_same_v<T, int64_t>) {
value = number.longLongValue;
} else if constexpr (std::is_same_v<T, float>) {
value = number.floatValue;
} else if constexpr (std::is_same_v<T, double>) {
value = number.doubleValue;
} else if constexpr (std::is_same_v<T, BOOL>) {
value = number.boolValue;
} else if constexpr (std::is_same_v<T, uint16_t>) {
value = number.unsignedShortValue;
} else if constexpr (std::is_same_v<T, uint32_t>) {
value = number.unsignedIntValue;
} else if constexpr (std::is_same_v<T, uint64_t>) {
value = number.unsignedLongLongValue;
} else if constexpr (std::is_same_v<T, NSInteger>) {
value = number.integerValue;
} else if constexpr (std::is_same_v<T, NSUInteger>) {
value = number.unsignedIntegerValue;
} else if constexpr (std::is_same_v<T, BFloat16> ||
std::is_same_v<T, Half>) {
value = T(number.floatValue);
} else {
static_assert(sizeof(T) == 0, "Unsupported type");
}
ET_DCHECK_MSG(std::numeric_limits<T>::lowest() <= value && value <= std::numeric_limits<T>::max(),
"Value out of range");
return value;
}

} // namespace executorch::extension::utils

#endif // __cplusplus
Loading