error: aggregate ‘std::array<char, 64> hostname’ has incomplete type and cannot be defined

[Bidski]

Trying to build gloo via pytorch (this commit) and receiving this error

pytorch/third_party/gloo/gloo/transport/tcp/device.cc: In function ‘gloo::transport::tcp::attr gloo::transport::tcp::CreateDeviceAttr(const attr&)’:
pytorch/third_party/gloo/gloo/transport/tcp/device.cc:151:39: error: aggregate ‘std::array<char, 64> hostname’ has incomplete type and cannot be defined
  151 |       std::array<char, HOST_NAME_MAX> hostname;
      |                                       ^~~~~~~~

Adding #include <array> to the top of gloo/transport/tcp/device.cc resolves the error

[Bidski]

Looks like this commit may have introduced this bug

[hmaarrfk]

diff --git a/gloo/transport/tcp/device.cc b/gloo/transport/tcp/device.cc
index 05cf0a4..6aa48f5 100644
--- a/gloo/transport/tcp/device.cc
+++ b/gloo/transport/tcp/device.cc
@@ -12,6 +12,7 @@
 #include <netdb.h>
 #include <netinet/in.h>
 #include <string.h>
+#include <array>
 
 #include "gloo/common/linux.h"
 #include "gloo/common/logging.h"
diff --git a/gloo/transport/tcp/tls/pair.cc b/gloo/transport/tcp/tls/pair.cc
index 176fa5e..bf39bbf 100644
--- a/gloo/transport/tcp/tls/pair.cc
+++ b/gloo/transport/tcp/tls/pair.cc
@@ -17,6 +17,7 @@
 
 #include <cstring>
 #include <poll.h>
+#include <array>
 
 namespace gloo {
 namespace transport {

Seems like it addresses thing.

[lindsayad]

Does anyone know why the associated PR #333 was closed? This seems like the kind of thing that should have been fixed the moment it was reported. It's a one-line fix

[xgupta]

Does anyone know why the associated PR #333 was closed? This seems like the kind of thing that should have been fixed the moment it was reported. It's a one-line fix

Not sure, A commit is already made to fix the issue - 4a5e339.

[xgupta]

Okay to close this issue?