[CI] Fix AMD journal check errors #1016
Merged
+41
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
yf225
force-pushed
the
ci_amd_journal_errors
branch
from
b71644e to
a2905be
Compare
yf225
changed the title
yf225
force-pushed
the
ci_amd_journal_errors
branch
from
a2905be to
ad79780
Compare
yf225
changed the title
yf225
force-pushed
the
ci_amd_journal_errors
branch
from
ad79780 to
b7e6cb8
Compare
yf225
changed the title
yf225
force-pushed
the
ci_amd_journal_errors
branch
from
b7e6cb8 to
4cf2672
Compare
yf225
changed the title
oulgen
reviewed
Oct 24, 2025
Comment on lines
+776
to
+777
| # libdevice.rsqrt( -> tl.rsqrt( | ||
| code = re.sub(r"\blibdevice\.rsqrt\s*\(", "tl.rsqrt(", code) |
There was a problem hiding this comment.
this one actually shows up in AMD tests:
2025-10-24T16:25:05.3039413Z E - v_8 = tl.rsqrt(v_7)
2025-10-24T16:25:05.3039489Z E ? -
2025-10-24T16:25:05.3039637Z E + v_8 = libdevice.rsqrt(v_7)
2025-10-24T16:25:05.3039708Z E ? ++++++++
oulgen
approved these changes
Oct 24, 2025
yf225
force-pushed
the
ci_amd_journal_errors
branch
4 times, most recently
from
7ac0c8d to
0fdd940
Compare
yf225
force-pushed
the
ci_amd_journal_errors
branch
from
0fdd940 to
a75a29b
Compare
tianrengao
pushed a commit
that referenced
this pull request
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example errors: https://github.com/pytorch/helion/actions/runs/18785628887/job/53603049036