Skip to content

add geglu backward #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2025
Merged

add geglu backward #1069

merged 1 commit into from
Nov 4, 2025

Conversation

@parsshar-RH
Copy link
Contributor

@parsshar-RH parsshar-RH commented Nov 3, 2025

Summary:

This PR adds backward pass to the existing GEGLU kernel implementation.

Benchmark:

=================================================================
Benchmark Results
=================================================================
Implementation       Time (ms)    Speedup        
-----------------------------------------------------------------
helion_autograd      0.3720       1.79x          
torch                0.6667       1.00x (ref)    
=================================================================

✓ GEGLU kernel shape (8, 4096, 8192) passed

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 3, 2025
@jansel jansel merged commit 5aad251 into pytorch:main Nov 4, 2025
14 checks passed
tianrengao pushed a commit that referenced this pull request Nov 5, 2025
@parsshar-RH @tianrengao
add geglu backward (#1069)
2578b6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@parsshar-RH @jansel