Fix builtin min / max handling in device loop #1085
Merged
+235
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
yf225
force-pushed
the
fix_gated_delta_net_1067_issue
branch
from
2956740 to
1a718f2
Compare
yf225
force-pushed
the
fix_gated_delta_net_1067_issue
branch
23 times, most recently
from
7c96893 to
0779ba6
Compare
yf225
force-pushed
the
fix_gated_delta_net_1067_issue
branch
2 times, most recently
from
d620f11 to
af6c723
Compare
yf225
force-pushed
the
fix_gated_delta_net_1067_issue
branch
from
af6c723 to
39c206d
Compare
yf225
commented
Nov 5, 2025
| ) | ||
| ast.parse(code) | ||
|
|
||
| @skipIfPyTorchBaseVerLessThan("2.10") |
Contributor
Author
There was a problem hiding this comment.
PyTorch 2.9 has a indexing expression related bug that's only fixed in PyTorch nightly: pytorch/pytorch#131761. Making a patch for that in Helion framework is quite complicated, thus we skip this unit test unless we are on 2.10 version (including current nightly).
jansel
approved these changes
Nov 7, 2025
| if isinstance(x, int): | ||
| return sympy.Integer(x) | ||
| if isinstance(x, sympy.Expr): | ||
| return sympy.simplify(x) |
Contributor
There was a problem hiding this comment.
Is there a need to simplify here? We don't simplify if given a symint. (Note sympify!=simplify)
Contributor
Author
There was a problem hiding this comment.
agreed we don't have to simplify here (was copying from existing resolve_block_id code, but removing it also passes tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1067.