Refactor _decorators.codegen to allow multiple backends #1099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack-info: PR: #1099, branch: jansel/stack/220
jansel
force-pushed
the
jansel/stack/220
branch
from
b190fc8 to
7dbc0af
Compare
jansel
added a commit
that referenced
this pull request
Nov 7, 2025
stack-info: PR: #1099, branch: jansel/stack/220
jansel
force-pushed
the
jansel/stack/219
branch
from
3588cad to
c500db4
Compare
meta-cla
bot
added
the
CLA Signed
jansel
force-pushed
the
jansel/stack/220
branch
from
7dbc0af to
8eb852f
Compare
Merged
jansel
force-pushed
the
jansel/stack/220
branch
2 times, most recently
from
5f83a1a to
2bb4401
Compare
oulgen
approved these changes
Nov 7, 2025
|
|
||
|
|
||
| @_decorators.codegen(_get_symnode) | ||
| @_decorators.codegen(_get_symnode, "triton") |
Contributor
There was a problem hiding this comment.
instead of hardcoding the string here, can we use an enum?
Contributor
Author
There was a problem hiding this comment.
This would make out-of-tree backends harder to implement.
jansel
force-pushed
the
jansel/stack/220
branch
from
2bb4401 to
88e4378
Compare
jansel
added a commit
that referenced
this pull request
Nov 7, 2025
stack-info: PR: #1099, branch: jansel/stack/220
jansel
force-pushed
the
jansel/stack/220
branch
from
88e4378 to
e8d3ad9
Compare
jansel
force-pushed
the
jansel/stack/221
branch
from
30363cd to
0155149
Compare
jansel
added a commit
that referenced
this pull request
Nov 7, 2025
stack-info: PR: #1099, branch: jansel/stack/220
jansel
force-pushed
the
jansel/stack/220
branch
from
e8d3ad9 to
dabf3ac
Compare
jansel
force-pushed
the
jansel/stack/221
branch
from
0155149 to
5c9d6aa
Compare
jansel
added a commit
that referenced
this pull request
Nov 7, 2025
stack-info: PR: #1099, branch: jansel/stack/220
jansel
force-pushed
the
jansel/stack/220
branch
2 times, most recently
from
1f58163 to
95c6eb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs (oldest at bottom):
Refactor _decorators.codegen to allow multiple backends