Add skipIfRocm to failing test on main #1101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansel
force-pushed
the
jansel/stack/222
branch
from
482ce3f to
38c670c
Compare
This was referenced Nov 7, 2025
Merged
meta-cla
bot
added
the
CLA Signed
oulgen
reviewed
Nov 7, 2025
| class TestTorchCompile(RefEagerTestBase, TestCase): | ||
| @skipIfRefEager("does not work with ref eager") | ||
| @skipIfPy314("torch.compile not yet supported on Python 3.14") | ||
| @skipIfRocm("torch.compile add kernel missing kernel metadata fields on ROCm") |
Contributor
There was a problem hiding this comment.
will already fixed this, rocm just needs a new nightly, perhaps we should just pin rocm to stable 2.9 instead?
oulgen
approved these changes
Nov 7, 2025
Contributor
oulgen
left a comment
oulgen
left a comment
There was a problem hiding this comment.
up to you, i'm fine either way
Contributor
Author
|
@oulgen main is still failing: https://github.com/pytorch/helion/actions/runs/19159684573/job/54767427636 |
jansel
force-pushed
the
jansel/stack/222
branch
from
38c670c to
c21d2e4
Compare
stack-info: PR: #1101, branch: jansel/stack/222
jansel
force-pushed
the
jansel/stack/222
branch
from
c21d2e4 to
cabdba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs (oldest at bottom):
Add skipIfRocm to failing test on main