Skip to content

Add skipIfRocm to failing test on main #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2025
Merged

Add skipIfRocm to failing test on main #1101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/test_torch_compile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,14 @@
from helion._testing import TestCase
from helion._testing import skipIfPy314
from helion._testing import skipIfRefEager
from helion._testing import skipIfRocm
import helion.language as hl


class TestTorchCompile(RefEagerTestBase, TestCase):
@skipIfRefEager("does not work with ref eager")
@skipIfPy314("torch.compile not yet supported on Python 3.14")
@skipIfRocm("torch.compile add kernel missing kernel metadata fields on ROCm")
Copy link
Contributor

@oulgen oulgen Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will already fixed this, rocm just needs a new nightly, perhaps we should just pin rocm to stable 2.9 instead?

def test_add_kernel(self):
@helion.kernel(config=helion.Config(block_sizes=[1, 2]))
def add(x: torch.Tensor, y: torch.Tensor) -> torch.Tensor:
Expand Down
Loading