Fix CI to surface errors correctly, fix all existing errors #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yf225
commented
Nov 15, 2025
yf225
commented
- Revert "[CI] Fix fbcode test_breakpoint error (]"
- skip breakpoint tests on fbcode
- Fail CI job on any test error
meta-cla
bot
added
the
CLA Signed
yf225
commented
Nov 15, 2025
| - name: Run Tests | ||
| run: | | ||
| set -o pipefail |
Contributor
Author
There was a problem hiding this comment.
without this, the oss CI is currently swallowing all errors :(
Contributor
There was a problem hiding this comment.
this was not the case previously? so what changed?
yf225
changed the title
Contributor
|
@yf225 let's wait for code review before landing changes in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.