Workaround TRITON_INTERPRET bug breaking tests #1139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansel
added a commit
that referenced
this pull request
Nov 15, 2025
See triton-lang/triton#8735 stack-info: PR: #1139, branch: jansel/stack/228
jansel
force-pushed
the
jansel/stack/228
branch
from
c426776 to
dc05276
Compare
meta-cla
bot
added
the
CLA Signed
Contributor
|
sorry I saw this too late :( I just landed #1138 to fix the CI error surfacing, and also switch back to using subprocess for breakpoint tests to unblock the CI but I still think this PR would be a better fix, as with it we can avoid use of subprocess |
jansel
added a commit
that referenced
this pull request
Nov 15, 2025
See triton-lang/triton#8735 stack-info: PR: #1139, branch: jansel/stack/228
jansel
force-pushed
the
jansel/stack/228
branch
from
dc05276 to
3b8a5ba
Compare
Contributor
Author
|
I update this PR to revert the subprocess stuff. I think the upstream Triton fix is a cleaner solution. |
See triton-lang/triton#8735 stack-info: PR: #1139, branch: jansel/stack/228
jansel
force-pushed
the
jansel/stack/228
branch
from
3b8a5ba to
094c5d6
Compare
yf225
approved these changes
Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs (oldest at bottom):
Workaround TRITON_INTERPRET bug breaking tests
See triton-lang/triton#8735