Skip to content

Workaround TRITON_INTERPRET bug breaking tests #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2025
Merged

Workaround TRITON_INTERPRET bug breaking tests #1139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 19 additions & 85 deletions test/test_breakpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,13 @@
import builtins
from contextlib import contextmanager
import os
import subprocess
import sys
import textwrap
from typing import TYPE_CHECKING
import unittest
from unittest import mock

import torch
from torch._environment import is_fbcode
import triton.runtime.interpreter as triton_interpreter

import helion
from helion import exc
Expand Down Expand Up @@ -67,42 +65,6 @@ def kernel(x: torch.Tensor) -> torch.Tensor:

return kernel

def _run_breakpoint_in_subprocess(
self,
*,
test_name: str,
runner_method: str,
triton_interpret: int,
helion_interpret: int,
) -> None:
"""Run a breakpoint test in a subprocess to isolate interpreter state."""
script = textwrap.dedent(
f"""
from test.test_breakpoint import TestBreakpoint

case = TestBreakpoint({test_name!r})
case.setUp()
try:
getattr(case, {runner_method!r})(triton_interpret={triton_interpret}, helion_interpret={helion_interpret})
finally:
case.tearDown()
"""
)

env = os.environ.copy()
result = subprocess.run(
[sys.executable, "-c", script],
env=env,
capture_output=True,
)
if result.returncode != 0:
raise AssertionError(
f"{test_name} subprocess failed",
result.returncode,
result.stdout.decode(),
result.stderr.decode(),
)

def _run_device_breakpoint_test(
self, triton_interpret: int, helion_interpret: int
) -> None:
Expand All @@ -129,32 +91,18 @@ def _run_device_breakpoint_test(
out = bound(x)
torch.testing.assert_close(out, x)

@unittest.skipIf(is_fbcode(), "subprocess test doesn't work in internal CI")
def test_device_breakpoint_no_interpret(self) -> None:
self._run_breakpoint_in_subprocess(
test_name=self._testMethodName,
runner_method="_run_device_breakpoint_test",
triton_interpret=0,
helion_interpret=0,
)

@unittest.skipIf(is_fbcode(), "subprocess test doesn't work in internal CI")
self._run_device_breakpoint_test(triton_interpret=0, helion_interpret=0)

@unittest.skipUnless(
hasattr(triton_interpreter, "_MISSING"),
"https://github.com/triton-lang/triton/pull/8735",
)
def test_device_breakpoint_triton_interpret(self) -> None:
self._run_breakpoint_in_subprocess(
test_name=self._testMethodName,
runner_method="_run_device_breakpoint_test",
triton_interpret=1,
helion_interpret=0,
)

@unittest.skipIf(is_fbcode(), "subprocess test doesn't work in internal CI")
self._run_device_breakpoint_test(triton_interpret=1, helion_interpret=0)

def test_device_breakpoint_helion_interpret(self) -> None:
self._run_breakpoint_in_subprocess(
test_name=self._testMethodName,
runner_method="_run_device_breakpoint_test",
triton_interpret=0,
helion_interpret=1,
)
self._run_device_breakpoint_test(triton_interpret=0, helion_interpret=1)

def _run_host_breakpoint_test(
self, triton_interpret: int, helion_interpret: int
Expand All @@ -173,32 +121,18 @@ def _run_host_breakpoint_test(
out = bound(x)
torch.testing.assert_close(out, x)

@unittest.skipIf(is_fbcode(), "subprocess test doesn't work in internal CI")
def test_host_breakpoint_no_interpret(self) -> None:
self._run_breakpoint_in_subprocess(
test_name=self._testMethodName,
runner_method="_run_host_breakpoint_test",
triton_interpret=0,
helion_interpret=0,
)

@unittest.skipIf(is_fbcode(), "subprocess test doesn't work in internal CI")
self._run_host_breakpoint_test(triton_interpret=0, helion_interpret=0)

@unittest.skipUnless(
hasattr(triton_interpreter, "_MISSING"),
"https://github.com/triton-lang/triton/pull/8735",
)
def test_host_breakpoint_triton_interpret(self) -> None:
self._run_breakpoint_in_subprocess(
test_name=self._testMethodName,
runner_method="_run_host_breakpoint_test",
triton_interpret=1,
helion_interpret=0,
)

@unittest.skipIf(is_fbcode(), "subprocess test doesn't work in internal CI")
self._run_host_breakpoint_test(triton_interpret=1, helion_interpret=0)

def test_host_breakpoint_helion_interpret(self) -> None:
self._run_breakpoint_in_subprocess(
test_name=self._testMethodName,
runner_method="_run_host_breakpoint_test",
triton_interpret=0,
helion_interpret=1,
)
self._run_host_breakpoint_test(triton_interpret=0, helion_interpret=1)


if __name__ == "__main__":
Expand Down
4 changes: 3 additions & 1 deletion test/test_print.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

import pytest
import torch
import triton.runtime.interpreter as triton_interpreter

import helion
from helion._testing import DEVICE
Expand Down Expand Up @@ -99,7 +100,8 @@ def run_test_with_and_without_triton_interpret_envvar(self, test_func):
os.environ.pop("TRITON_INTERPRET", None)
test_func(interpret_mode=False)

# Then run with TRITON_INTERPRET=1
if not hasattr(triton_interpreter, "_MISSING"):
return # see https://github.com/triton-lang/triton/pull/8735
os.environ["TRITON_INTERPRET"] = "1"
test_func(interpret_mode=True)
finally:
Expand Down
Loading