fix shape bug in lfbo pattern search #1170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running some additional benchmarks, I realized that for some kernels, there are many configs that give identical performance (e.g. for rms_norm). Originally, LFBO Pattern Search construct training labels by classifying which configs have performance strictly better than quantile(perfs, 0.3). Since this comparison is strict, in cases where the performance of the top 30% of configs is identical, then all the labels are zero. Training with these labels doesn't throw an error but instead when we call predict_proba, this returns all a 1D tensor of all zeros instead of a 2d tensor of probabilities for each class.
Now this is fixed by constructing labels with a non-strict comparison. We also explicitly deal with the case where all the labels are identical by arbitrarily flipping the first one.