Skip to content

Conversation

@oulgen
Copy link
Contributor

@oulgen oulgen commented Dec 1, 2025

Stacked PRs:


[CI] remove all conda and move to uv

stack-info: PR: #1181, branch: oulgen/stack/177
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 1, 2025
@oulgen oulgen requested review from jansel and yf225 December 1, 2025 19:19
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, though if you are using github runners, why not use https://github.com/actions/setup-python and rely on whatever mechanism GH prefers?

@oulgen oulgen merged commit 64061aa into main Dec 1, 2025
15 of 16 checks passed
@oulgen
Copy link
Contributor Author

oulgen commented Dec 1, 2025

SGTM, though if you are using github runners, why not use https://github.com/actions/setup-python and rely on whatever mechanism GH prefers?

i need to still pip install stuff, isnt uv pip faster?

@malfet
Copy link
Contributor

malfet commented Dec 1, 2025

SGTM, though if you are using github runners, why not use https://github.com/actions/setup-python and rely on whatever mechanism GH prefers?

i need to still pip install stuff, isnt uv pip faster?

I don't know, but setup-python have some mechanism for caching those installs across invocations, which probably makes it more reliable, but all of that is moot at this point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants