Skip to content

Conversation

@yf225
Copy link
Contributor

@yf225 yf225 commented Sep 7, 2025

Local environments usually have HELION_USE_DEFAULT_CONFIG=1 on by default to do development on non-autotuner features, and some local envs also have low available GPU memory.

This PR adds use_default_config=False explicitly to specific unit tests so that they still work even if HELION_USE_DEFAULT_CONFIG=1 is set, and also skip specific unit tests when GPU VRAM is low.

@yf225 yf225 requested review from jansel and oulgen September 7, 2025 03:22
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 7, 2025
@yf225 yf225 changed the title Add skipIfLowVRAM or use_default_config=False to specific unit tests Add skipIfLowVRAM or use_default_config=False to specific unit tests for local testing Sep 7, 2025
@yf225 yf225 changed the title Add skipIfLowVRAM or use_default_config=False to specific unit tests for local testing Add skipIfLowVRAM or use_default_config=False to specific unit tests to enable local testing Sep 7, 2025
@yf225 yf225 merged commit 87ccb4d into main Sep 7, 2025
13 checks passed

def test_autotuner_disabled(self):
@helion.kernel
@helion.kernel(use_default_config=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the env var not override this? 🫨

lolpack pushed a commit to lolpack/helion that referenced this pull request Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants