Do not benchmark twice #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently we end up compiling the same kernel 4 times i think. 1 precompile and 1 cached compile during iter_candidates and another set of these again in benchmark_flat. stack-info: PR: #583, branch: oulgen/stack/91
oulgen
force-pushed
the
oulgen/stack/91
branch
from
124cfb1 to
9bd2393
Compare
meta-cla
bot
added
the
CLA Signed
jansel
approved these changes
Sep 10, 2025
lolpack
pushed a commit
to lolpack/helion
that referenced
this pull request
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Do not benchmark twice
currently we end up compiling the same kernel 4 times i think. 1
precompile and 1 cached compile during iter_candidates and another set
of these again in benchmark_flat.