Fix rms_norm and layer_norm #603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@mengluy0125 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82608162. |
mengluy0125
added a commit
to mengluy0125/helion
that referenced
this pull request
Sep 17, 2025
Summary: 1. Add layer_norm_tritonbench for layer_norm to tailor to the tritonebench interface 2. RMS tensor should be the shape of [M, 1] Differential Revision: D82608162
mengluy0125
force-pushed
the
export-D82608162
branch
from
f96a61b to
80ebf26
Compare
|
@mengluy0125 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82608162. |
yf225
approved these changes
Sep 17, 2025
mengluy0125
force-pushed
the
export-D82608162
branch
from
80ebf26 to
98c46e5
Compare
mengluy0125
added a commit
to mengluy0125/helion
that referenced
this pull request
Sep 17, 2025
Summary: 1. Add layer_norm_tritonbench for layer_norm to tailor to the tritonebench interface 2. RMS tensor should be the shape of [M, 1] Differential Revision: D82608162
|
@mengluy0125 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82608162. |
|
CI has been giving weird error: |
Summary: 1. Add layer_norm_tritonbench for layer_norm to tailor to the tritonebench interface 2. RMS tensor should be the shape of [M, 1] Differential Revision: D82608162
mengluy0125
force-pushed
the
export-D82608162
branch
from
98c46e5 to
5b77ee3
Compare
|
@mengluy0125 has exported this pull request. If you are a Meta employee, you can view the originating diff in D82608162. |
jansel
approved these changes
Sep 17, 2025
lolpack
pushed a commit
to lolpack/helion
that referenced
this pull request
Oct 13, 2025
Differential Revision: D82608162 Pull Request resolved: pytorch#603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add layer_norm_tritonbench for layer_norm to tailor to the tritonebench interface
RMS tensor should be the shape of [M, 1]
Differential Revision: D82608162