Skip to content

Adjust tolerance for test_rms_norm_bwd_dx #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2025
Merged

Adjust tolerance for test_rms_norm_bwd_dx #628

merged 1 commit into from
Sep 18, 2025

Conversation

@yf225
Copy link
Contributor

@yf225 yf225 commented Sep 18, 2025 •
edited
Loading

Recently I have seen this mismatch error on CI:

FAILED test/test_examples.py::TestExamples::test_rms_norm_bwd_dx - AssertionError: Tensor-likes are not close!

Mismatched elements: 1 / 2048 (0.0%)
Greatest absolute difference: 0.00146484375 at index (29, 19) (up to 0.001 allowed)
Greatest relative difference: 0.004338394850492477 at index (29, 19) (up to 0.001 allowed)

e.g. https://github.com/pytorch/helion/actions/runs/17841339611/job/50731357865?pr=620

@yf225 yf225 requested review from jansel and oulgen September 18, 2025 21:28
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 18, 2025
@yf225 yf225 merged commit 62bbcaf into main Sep 18, 2025
13 checks passed
@yf225 yf225 deleted the rms_norm_backward_test_tol branch September 18, 2025 22:39
lolpack pushed a commit to lolpack/helion that referenced this pull request Oct 13, 2025
@yf225 @lolpack
Adjust tolerance for test_rms_norm_bwd_dx (pytorch#628)
75346b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oulgen oulgen oulgen approved these changes

@jansel jansel Awaiting requested review from jansel

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yf225 @oulgen