-
Notifications
You must be signed in to change notification settings - Fork 61
Print Helion kernel source line in symbolic shape debugging #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yf225
added a commit
that referenced
this pull request
Oct 2, 2025
stack-info: PR: #771, branch: yf225/stack/61
yf225
added a commit
that referenced
this pull request
Oct 2, 2025
With `TORCH_LOGS="+dynamic"`, now it prints: ``` I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] create_unbacked_symint u0 [-int_oo, int_oo] I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] Helion kernel stack: I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] File "/home/willfeng/local/helion2/minimal_repro.py", line 10, in logging_reduce_rows I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] m_block = hl.register_block_size(m) I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] ^^^^^^^^^^^^^^^^^^^^^^^^^ ``` which can be further traced with TORCHDYNAMO_EXTENDED_DEBUG_CREATE_SYMBOL="u0" stack-info: PR: #771, branch: yf225/stack/61
yf225
added a commit
that referenced
this pull request
Oct 2, 2025
With `TORCH_LOGS="+dynamic"`, now it prints: ``` I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] create_unbacked_symint u0 [-int_oo, int_oo] I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] Helion kernel stack: I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] File "/home/willfeng/local/helion2/minimal_repro.py", line 10, in logging_reduce_rows I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] m_block = hl.register_block_size(m) I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] ^^^^^^^^^^^^^^^^^^^^^^^^^ ``` which can be further traced with `TORCHDYNAMO_EXTENDED_DEBUG_CREATE_SYMBOL="u0"` stack-info: PR: #771, branch: yf225/stack/61
oulgen
approved these changes
Oct 2, 2025
yf225
added a commit
that referenced
this pull request
Oct 2, 2025
With `TORCH_LOGS="+dynamic"`, now it prints: ``` I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] create_unbacked_symint u0 [-int_oo, int_oo] I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] Helion kernel stack: I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] File "/home/willfeng/local/helion2/minimal_repro.py", line 10, in logging_reduce_rows I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] m_block = hl.register_block_size(m) I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] ^^^^^^^^^^^^^^^^^^^^^^^^^ ``` which can be further traced with `TORCHDYNAMO_EXTENDED_DEBUG_CREATE_SYMBOL="u0"` stack-info: PR: #771, branch: yf225/stack/61
yf225
added a commit
that referenced
this pull request
Oct 2, 2025
With `TORCH_LOGS="+dynamic"`, now it prints: ``` I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] create_unbacked_symint u0 [-int_oo, int_oo] I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] Helion kernel stack: I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] File "/home/willfeng/local/helion2/minimal_repro.py", line 10, in logging_reduce_rows I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] m_block = hl.register_block_size(m) I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] ^^^^^^^^^^^^^^^^^^^^^^^^^ ``` which can be further traced with `TORCHDYNAMO_EXTENDED_DEBUG_CREATE_SYMBOL="u0"` stack-info: PR: #771, branch: yf225/stack/61
jansel
approved these changes
Oct 2, 2025
With `TORCH_LOGS="+dynamic"`, now it prints: ``` I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] create_unbacked_symint u0 [-int_oo, int_oo] I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] Helion kernel stack: I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] File "/home/willfeng/local/helion2/minimal_repro.py", line 10, in logging_reduce_rows I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] m_block = hl.register_block_size(m) I1001 20:49:16.995000 1208064 torch/fx/experimental/symbolic_shapes.py:4800] ^^^^^^^^^^^^^^^^^^^^^^^^^ ``` which can be further traced with `TORCHDYNAMO_EXTENDED_DEBUG_CREATE_SYMBOL="u0"` stack-info: PR: #771, branch: yf225/stack/61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Print Helion kernel source line in symbolic shape debugging
With
TORCH_LOGS="+dynamic", now it prints:which can be further traced with
TORCHDYNAMO_EXTENDED_DEBUG_CREATE_SYMBOL="u0"