Skip to content

Allow TrainsSaver to be initialized with no logger #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 16, 2020
Merged

Allow TrainsSaver to be initialized with no logger #1043

merged 7 commits into from
May 16, 2020

Conversation

@jkhenning
Copy link
Contributor

@jkhenning jkhenning commented May 16, 2020

Fixes #1039

Description:
Allow creating a TrainsSaver instance with no logger argument, assuming the user has already initialized a Trains Task using trains.Task.init(). If a Trains Task was not initialized, show a runtime error.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@jkhenning jkhenning mentioned this pull request May 16, 2020
Closed
vfdev-5
vfdev-5 approved these changes May 16, 2020
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jkhenning !

@vfdev-5
Copy link
Collaborator

vfdev-5 commented May 16, 2020

@jkhenning seems like test_trains_disk_saver_integration is broken now:
https://travis-ci.org/github/pytorch/ignite/jobs/687746212#L1952

@vfdev-5 vfdev-5 merged commit 7e3ee04 into pytorch:master May 16, 2020
@jkhenning jkhenning deleted the trains-fix-disk-saver branch May 17, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TrainsSaver requires TrainsLogger but doesn't use it

2 participants

@jkhenning @vfdev-5