Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ignite/contrib/engines/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ def _setup_logging(logger, trainer, optimizers, evaluators, log_every_iters):

if evaluators is not None:
if not isinstance(evaluators, (Engine, Mapping)):
raise TypeError("Argument optimizers should be either a single optimizer or a dictionary or optimizers")
raise TypeError("Argument evaluators should be either a single engine or a dictionary or engines")

if log_every_iters is None:
log_every_iters = 1
Expand Down
10 changes: 8 additions & 2 deletions ignite/contrib/handlers/polyaxon_logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,15 @@ class PolyaxonLogger(BaseLogger):
param_name='lr' # optional
)

Args:
*args: Positional arguments accepted from
`Experiment <https://docs.polyaxon.com/references/polyaxon-tracking-api/experiments/>`_.
**kwargs: Keyword arguments accepted from
`Experiment <https://docs.polyaxon.com/references/polyaxon-tracking-api/experiments/>`_.

"""

def __init__(self):
def __init__(self, *args, **kwargs):
try:
from polyaxon_client.tracking import Experiment
except ImportError:
Expand All @@ -262,7 +268,7 @@ def __init__(self):
"Please install it with command: \n pip install polyaxon-client"
)

self.experiment = Experiment()
self.experiment = Experiment(*args, **kwargs)

def __getattr__(self, attr):
def wrapper(*args, **kwargs):
Expand Down
21 changes: 21 additions & 0 deletions tests/ignite/contrib/conftest.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import pytest


@pytest.fixture()
def visdom_server():

import os
import signal
import subprocess
import time

from visdom.server import download_scripts

download_scripts()

hostname = "localhost"
port = 8098
p = subprocess.Popen("visdom --hostname {} -port {}".format(hostname, port), shell=True, preexec_fn=os.setsid)
time.sleep(5)
yield (hostname, port)
os.killpg(os.getpgid(p.pid), signal.SIGTERM)
Loading