Skip to content

Add None check for max_epochs #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 22, 2020
Merged

Add None check for max_epochs #1519

merged 3 commits into from
Dec 22, 2020

Conversation

@gruebel
Copy link
Contributor

@gruebel gruebel commented Dec 22, 2020

Fixes #1513

I hope it fits your expectations 😄

The param_scheduler change was due to flake8 warning of 120+ chars

vfdev-5
vfdev-5 reviewed Dec 22, 2020
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @gruebel !
I left a comment about how to define total_iters.

@vfdev-5 vfdev-5 merged commit e3ef192 into pytorch:master Dec 22, 2020
@vfdev-5 vfdev-5 mentioned this pull request Dec 22, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 vfdev-5 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve typing in engine

2 participants

@gruebel @vfdev-5