Skip to content

Conversation

@trsvchn
Copy link
Collaborator

@trsvchn trsvchn commented Mar 5, 2021

This PR adds automatic issue and pr labelers

Issue labeler adds labels based on the body content of the issue.

PR labeler adds labels s based on the paths that are modified in the PR.

Description:

Here is demo from my fork:

trsvchn#13
trsvchn#14

All labels are defined in config files in .github/*-labeler.yml

Some of them are disabled:

https://github.com/trsvchn/ignite/blob/b55ce8331316cba55b2d5cb12fe9c26d6182b067/.github/pr-labeler.yml#L9-L20

Since we need to create them in repo first, action doesn't create them for us just uses already available.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 5, 2021

Looks very cool @trsvchn ! Thanks for the FR !

@trsvchn
Copy link
Collaborator Author

trsvchn commented Mar 5, 2021

@vfdev-5 Please see the following experiments:

trsvchn#13 (comment)

@trsvchn
Copy link
Collaborator Author

trsvchn commented Mar 5, 2021

Issue labeler removes manually added labels

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 5, 2021

Yes, looks like that...

@trsvchn
Copy link
Collaborator Author

trsvchn commented Mar 5, 2021

As possible solution, we can use it only on issue opening, to label it once

@trsvchn
Copy link
Collaborator Author

trsvchn commented Mar 5, 2021

Or create a subset of labels just for labeler: a kind of:

  • "triage: docs"
  • "triage: docker"
  • etc

@trsvchn
Copy link
Collaborator Author

trsvchn commented Mar 5, 2021

@vfdev-5

I've removed triggering on issue editing for Issue Labeler, since we are actively using labels on issues, So we will have only one labeling on opening issue, and then we can add some labels with no worries.

Triggering for PR Labeler left unchanged, since I've noticed we are not using labels for PR at all, so it is not going to affect any labeling system.

@sdesrozis
Copy link
Contributor

sdesrozis commented Mar 5, 2021

@trsvchn Beyond technical issues that you are facing, I really enjoy this FR :)

@trsvchn
Copy link
Collaborator Author

trsvchn commented Mar 5, 2021

@sdesrozis Thanks!) Yes, I'm looking for solution where we can "coexist" with auto-labeling system, since labelers don't have a clue who added this label etc, and there is no way to inform them: "I know no docs are modified, but this PR/issue is logically connected to docs"

@trsvchn trsvchn changed the title [Feature] Auto Issue and PR labelers [Feature] Pull Request Auto Labeler Mar 5, 2021
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! Thanks @trsvchn

@vfdev-5 vfdev-5 merged commit f2c7713 into pytorch:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants