- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 657
 
[Feature] Pull Request Auto Labeler #1745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           Looks very cool @trsvchn ! Thanks for the FR !  | 
    
| 
           @vfdev-5 Please see the following experiments:  | 
    
| 
           Issue labeler removes manually added labels  | 
    
| 
           Yes, looks like that...  | 
    
| 
           As possible solution, we can use it only on issue opening, to label it once  | 
    
| 
           Or create a subset of labels just for labeler: a kind of: 
  | 
    
| 
          
 I've removed triggering on issue editing for Issue Labeler, since we are actively using labels on issues, So we will have only one labeling on opening issue, and then we can add some labels with no worries. Triggering for PR Labeler left unchanged, since I've noticed we are not using labels for PR at all, so it is not going to affect any labeling system.  | 
    
| 
           @trsvchn Beyond technical issues that you are facing, I really enjoy this FR :)  | 
    
| 
           @sdesrozis Thanks!) Yes, I'm looking for solution where we can "coexist" with auto-labeling system, since labelers don't have a clue who added this label etc, and there is no way to inform them: "I know no docs are modified, but this PR/issue is logically connected to docs"  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ! Thanks @trsvchn
This PR adds automatic issue and pr labelers
Issue labeler adds labels based on the body content of the issue.
PR labeler adds labels s based on the paths that are modified in the PR.
Description:
Here is demo from my fork:
trsvchn#13
trsvchn#14
All labels are defined in config files in
.github/*-labeler.ymlSome of them are disabled:
https://github.com/trsvchn/ignite/blob/b55ce8331316cba55b2d5cb12fe9c26d6182b067/.github/pr-labeler.yml#L9-L20
Since we need to create them in repo first, action doesn't create them for us just uses already available.
Check list: