improve average precision and tests #1756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KickItLikeShika thanks for the PR! Please, check this run: https://github.com/pytorch/ignite/pull/1756/checks?check_run_id=2060459202#step:6:32 |
|
@Moh-Yakoub could you please make any suggestion on how to refactor tests using pytest parametrize ? |
|
@vfdev-5 solved the doc error, waiting for @Moh-Yakoub suggestions |
|
Sounds good! Meanwhile, @KickItLikeShika, take a look at @Moh-Yakoub 's PR for accuracy: #1755 |
|
@vfdev-5, check the updates please, the tests have been refactored, and the docstring error has been solved. |
vfdev-5
reviewed
Mar 9, 2021
vfdev-5
approved these changes
Mar 9, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1695
We tried to improve the
contrib.metricsmodule at #1700 but we got some issues, the PR wasn't small, so it wasn't easy to solve these issues. I guess dividing this #1700 into smaller PRs will be better, and we would be able to solve these issues, i will create several PRs, each one contains the improvements for a one metric, and this is the first one foraverage_precision. In this PR the implementation and the tests ofaverage_precisionhave been updated as discussed before.Check list: