Skip to content

improve roc auc #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 13, 2021
Merged

improve roc auc #1762

merged 6 commits into from
Mar 13, 2021

Conversation

@KickItLikeShika
Copy link
Contributor

@KickItLikeShika KickItLikeShika commented Mar 10, 2021 •
edited
Loading

Our 3rd PR to improve ignite.contrib.metrics module. I have updated the implementation of roc_auc (added the device arg) and updated the tests as we have done with AveragePrecision.
Now we got precision_recall_curve and roc_curve left to be updated, but we will wait until EpochMetrics gets updated.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: contrib Contrib module label Mar 10, 2021
vfdev-5
vfdev-5 reviewed Mar 11, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @KickItLikeShika
There are few things to improve

vfdev-5
vfdev-5 reviewed Mar 11, 2021
View reviewed changes
@KickItLikeShika KickItLikeShika requested a review from vfdev-5 March 12, 2021 12:21
vfdev-5
vfdev-5 reviewed Mar 13, 2021
View reviewed changes
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 13, 2021

@KickItLikeShika PR looks OK, could you please open an issue explaining that we need to refactor in a certain way our tests such we do not duplicate the code. Metrics of the same type could have similar test suites.

@KickItLikeShika KickItLikeShika requested a review from vfdev-5 March 13, 2021 22:14
vfdev-5
vfdev-5 approved these changes Mar 13, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @KickItLikeShika !

@vfdev-5 vfdev-5 merged commit cc76de4 into pytorch:master Mar 13, 2021
@KickItLikeShika KickItLikeShika deleted the improve-roc-auc branch March 14, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees

No one assigned

Labels

module: contrib Contrib module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KickItLikeShika @vfdev-5