Skip to content

Conversation

@vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Mar 26, 2021

Original PR #1881

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

* hack inconsistency

* prepending hack
@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Mar 26, 2021

@KickItLikeShika if tests are passing here, let's apply the same trick to other tests of median related metrics.

@KickItLikeShika
Copy link
Contributor

@vfdev-5 unfortunately it didn't work..

@KickItLikeShika
Copy link
Contributor

KickItLikeShika commented Mar 26, 2021

I found the error! we did np_res_prepend = 100.0 * np.median(e) but it should be np_res_prepend = 100.0 * np.median(e_prepend).
I will send a follow up PR to fix that

* hack inconsistency

* prepending hack

* edit prepending

* edit assertion

* autopep8 fix

* delete blank lines

Co-authored-by: KickItLikeShika <KickItLikeShika@users.noreply.github.com>
@KickItLikeShika
Copy link
Contributor

@vfdev-5 It works fine now, thanks for providing such inspiring ideas! Thanks for your help!

@vfdev-5 vfdev-5 merged commit 05c5e19 into master Mar 26, 2021
@vfdev-5 vfdev-5 deleted the fix-med-abs-per-error branch March 26, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants