Skip to content

Conversation

@KickItLikeShika
Copy link
Contributor

Refactor tests, use pytest.mark.parametrize(), and improve test generation.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@KickItLikeShika
Copy link
Contributor Author

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Apr 5, 2021

@KickItLikeShika I think we can replace the link as :

- https://www.aclweb.org/anthology/P02-1040.pdf
+ https://www.aclweb.org/anthology/P02-1040

in another PR

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KickItLikeShika , lgtm!

@gucifer
Copy link
Contributor

gucifer commented Apr 5, 2021

@KickItLikeShika I think we can replace the link as :

- https://www.aclweb.org/anthology/P02-1040.pdf
+ https://www.aclweb.org/anthology/P02-1040

in another PR

The pdf link is still not working from there as well.
Let's add a working link like
https://dl.acm.org/doi/10.3115/1073083.1073135

Update: The issue is fixed, link is working again.

@KickItLikeShika
Copy link
Contributor Author

I agree with @gucifer

@KickItLikeShika
Copy link
Contributor Author

KickItLikeShika commented Apr 6, 2021

@vfdev-5 the link works fine now, please restart the Build docs test

@vfdev-5 vfdev-5 merged commit ccd9b63 into pytorch:master Apr 6, 2021
@KickItLikeShika KickItLikeShika deleted the improve-recall branch April 6, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants