Skip to content

chore: version change in EOS core handler [skip ci] #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2021
Merged

chore: version change in EOS core handler [skip ci] #1993

merged 1 commit into from
May 8, 2021

Conversation

@ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented May 8, 2021

Description

EpochOutputStore has been moved from contrib to core in #1982.
But the docstring said that this is new in v0.4.2 in core while it is actually moved in v0.5.0.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: handlers Core Handlers module label May 8, 2021
@ydcjeff ydcjeff changed the title chore: version change in EOS core handler chore: version change in EOS core handler [skip ci] May 8, 2021
@vfdev-5 vfdev-5 mentioned this pull request May 8, 2021
Merged
3 tasks
@vfdev-5
Copy link
Collaborator

vfdev-5 commented May 8, 2021

@ydcjeff I'm just wondering also if we should not also deprecate contrib EOS and still keep something in the docs like here : #1988
Maybe, we can do that in a follow-up PR.

vfdev-5
vfdev-5 approved these changes May 8, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ydcjeff

@vfdev-5 vfdev-5 merged commit 8c9f01a into pytorch:master May 8, 2021
@ydcjeff ydcjeff deleted the patch-1 branch May 9, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees

No one assigned

Labels

module: handlers Core Handlers module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ydcjeff @vfdev-5