Skip to content

Conversation

@Priyansi
Copy link
Contributor

@Priyansi Priyansi commented May 19, 2021

Description:

As discussed earlier with @vfdev-5 this will give us detailed insights into the documentation experience of the user and the suitable place to add this tag was discussed with @ydcjeff.

Also according to this article under Dynamic website -

Link the include file so that the snippet appears before the closing tag on every webpage you want to measure.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the docs label May 19, 2021
Copy link
Contributor

@ydcjeff ydcjeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Before merging, please confirm we are getting any traffic by visiting the preview link.

@Priyansi
Copy link
Contributor Author

Priyansi commented May 19, 2021

LGTM.
Before merging, please confirm we are getting any traffic by visiting the preview link.

@vfdev-5 since you have the access to the dashboard, can you please confirm this?

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @Priyansi !

@vfdev-5 vfdev-5 merged commit 42892e8 into pytorch:master May 19, 2021
@Priyansi Priyansi deleted the add-analytics-tag branch May 20, 2021 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants