Skip to content

Enabled gpu for gloo [test on gpus] #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 31, 2021
Merged

Enabled gpu for gloo [test on gpus] #2016

merged 5 commits into from
May 31, 2021

Conversation

@vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented May 31, 2021

Description:

  • Enabled gpu for gloo

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: distributed Distributed module label May 31, 2021
@vfdev-5 vfdev-5 changed the title Enabled gpu for gloo Enabled gpu for gloo [test on gpus] May 31, 2021
sdesrozis
sdesrozis approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use torch.cuda.is_available() and idist.device() rather than torch.device("xxx") is very nice !

LGTM.

@vfdev-5 vfdev-5 merged commit 2a4ed13 into master May 31, 2021
@vfdev-5 vfdev-5 deleted the enable-gpu-for-gloo branch May 31, 2021 13:55
@vfdev-5 vfdev-5 mentioned this pull request May 31, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sdesrozis sdesrozis sdesrozis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: distributed Distributed module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vfdev-5 @sdesrozis