Skip to content

Conversation

@justusschock
Copy link
Contributor

@justusschock justusschock commented Jan 24, 2020

Fixes #725

Description:
Adds __all__ to each source file to determine what should be imported, when users do from package.x import *

Check list:

  • New tests are added (if a new feature is added) [Not Necessary]
  • New doc strings: description and/or example code are in RST format [Not Necessary]
  • Documentation is updated (if required) [Not Necessary]

@justusschock justusschock requested a review from vfdev-5 January 24, 2020 10:36
@vfdev-5 vfdev-5 changed the title Add __all__ for all files Add __all__ for core part Jan 24, 2020
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justusschock LGTM, thanks !

@vfdev-5 vfdev-5 merged commit ef698d9 into pytorch:master Jan 24, 2020
@justusschock justusschock deleted the all_import branch January 24, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

__all__ for each source file

2 participants