-
-
Notifications
You must be signed in to change notification settings - Fork 657
issue #710 : add event list and or operator #868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sdesrozis I'm not a fan of introducing another public method for that. |
|
Now @vfdev-5 Is it better ? TODO doc |
|
Sorry, my bad, the name should remain as previously as
|
|
Last missing point is
|
|
@vfdev-5 you can comment :) |
|
@sdesrozis looks good to me. For perfect fit, I would put added section just after "Built-in events filtering"... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sdesrozis Thanks a lot for the PR !
PS: I changed the order of sections by myself as it can be done very quickly :)
Fixes #710
Description:
Add an event list class to pack events which could be added with operator
|onEventsandCallableEventWithFilterUser code is
TODO : improve doc
Check list: