Add additionalLoggerCollector mechanism to ActivityProfilerController (#1290)#1290
Closed
hjli-creator wants to merge 1 commit intopytorch:mainfrom
Closed
Add additionalLoggerCollector mechanism to ActivityProfilerController (#1290)#1290hjli-creator wants to merge 1 commit intopytorch:mainfrom
hjli-creator wants to merge 1 commit intopytorch:mainfrom
Conversation
|
@hjli-creator has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95829535. |
460df28 to
4a935d1
Compare
hjli-creator
added a commit
to hjli-creator/kineto
that referenced
this pull request
Mar 12, 2026
…pytorch#1290) Summary: Extend the ActivityProfilerController to support registering multiple additional LoggerCollector instances alongside the existing single factory. This enables plugging in supplementary logger observers (like a USDT probe logger) without replacing the primary UST logger collector. The additional collectors are registered/unregistered during controller construction/destruction. Differential Revision: D95829535
4a935d1 to
d769cc9
Compare
hjli-creator
added a commit
to hjli-creator/kineto
that referenced
this pull request
Mar 16, 2026
…pytorch#1290) Summary: Extend the ActivityProfilerController to support registering multiple additional LoggerCollector instances alongside the existing single factory. This enables plugging in supplementary logger observers (like a USDT probe logger) without replacing the primary UST logger collector. The additional collectors are registered/unregistered during controller construction/destruction. Differential Revision: D95829535
…pytorch#1290) Summary: Extend the ActivityProfilerController to support registering multiple additional LoggerCollector instances alongside the existing single factory. This enables plugging in supplementary logger observers (like a USDT probe logger) without replacing the primary UST logger collector. The additional collectors are registered/unregistered during controller construction/destruction. Differential Revision: D95829535
d769cc9 to
195f016
Compare
|
This pull request has been merged in bb1e194. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Extend the ActivityProfilerController to support registering multiple additional LoggerCollector instances alongside the existing single factory. This enables plugging in supplementary logger observers (like a USDT probe logger) without replacing the primary UST logger collector. The additional collectors are registered/unregistered during controller construction/destruction.
Differential Revision: D95829535