remove the rocprofiler early exit hack#1329
Closed
scotts wants to merge 1 commit intopytorch:mainfrom
Closed
Conversation
Summary: Remove the early exit hack because it seems to be doing more harm than good. Differential Revision: D98163400
|
This pull request has been merged in 0c8ede0. |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Apr 2, 2026
Includes the following commits: * Expose occupany limiting factors (pytorch/kineto#1330) * remove the rocprofiler early exit hack (pytorch/kineto#1329) * Remove duplicate test ignore (pytorch/kineto#1328) * Ensure that async doesn't loop while sync is active (pytorch/kineto#1327) * Add host_name to OSS Kineto trace metadata via gethostname() (pytorch/kineto#1323) * Revert D97166802 (pytorch/kineto#1326) * Fix Lingering INT32 Overflow (pytorch/kineto#1324) * Re-enabled some hardcoded tests (pytorch/kineto#1321) * Expose occupany limiting factors (pytorch/kineto#1322) Authored with Claude. Pull Request resolved: #178918 Approved by: https://github.com/divyanshk
scotts
added a commit
to scotts/pytorch
that referenced
this pull request
Apr 3, 2026
Includes the following commits: - remove the rocprofiler early exit hack (pytorch/kineto#1329) 0c8ede0 - Remove duplicate test ignore (pytorch/kineto#1328) 4826a43 - Ensure that async doesn't loop while sync is active (pytorch/kineto#1327) 37fada9 Authored with Claude.
weifengpy
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Apr 7, 2026
Includes the following commits: * Expose occupany limiting factors (pytorch/kineto#1330) * remove the rocprofiler early exit hack (pytorch/kineto#1329) * Remove duplicate test ignore (pytorch/kineto#1328) * Ensure that async doesn't loop while sync is active (pytorch/kineto#1327) * Add host_name to OSS Kineto trace metadata via gethostname() (pytorch/kineto#1323) * Revert D97166802 (pytorch/kineto#1326) * Fix Lingering INT32 Overflow (pytorch/kineto#1324) * Re-enabled some hardcoded tests (pytorch/kineto#1321) * Expose occupany limiting factors (pytorch/kineto#1322) Authored with Claude. Pull Request resolved: #178918 Approved by: https://github.com/divyanshk
scotts
added a commit
to scotts/pytorch
that referenced
this pull request
Apr 7, 2026
Includes the following commits: - remove the rocprofiler early exit hack (pytorch/kineto#1329) 0c8ede0 Authored with Claude.
nklshy-aws
pushed a commit
to nklshy-aws/pytorch
that referenced
this pull request
Apr 7, 2026
Includes the following commits: * Expose occupany limiting factors (pytorch/kineto#1330) * remove the rocprofiler early exit hack (pytorch/kineto#1329) * Remove duplicate test ignore (pytorch/kineto#1328) * Ensure that async doesn't loop while sync is active (pytorch/kineto#1327) * Add host_name to OSS Kineto trace metadata via gethostname() (pytorch/kineto#1323) * Revert D97166802 (pytorch/kineto#1326) * Fix Lingering INT32 Overflow (pytorch/kineto#1324) * Re-enabled some hardcoded tests (pytorch/kineto#1321) * Expose occupany limiting factors (pytorch/kineto#1322) Authored with Claude. Pull Request resolved: pytorch#178918 Approved by: https://github.com/divyanshk
pytorch-bot Bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Apr 8, 2026
Includes the following commits: - remove the rocprofiler early exit hack (pytorch/kineto#1329) 0c8ede0 Authored with Claude.
scotts
added a commit
to scotts/pytorch
that referenced
this pull request
Apr 9, 2026
Includes the following commits: - Fix GPU trace collection on ROCm by ensuring early rocprofiler-sdk tool registration (pytorch/kineto#1338) 4ff89e8 - Remove tb_plugin CI workflows (pytorch/kineto#1341) e335a7d - Remove INFO logs from kineto trace metadata to fix invalid JSON (pytorch/kineto#1336) 502c513 - Expose occupany limiting factors (pytorch/kineto#1330) 185fe9c - remove the rocprofiler early exit hack (pytorch/kineto#1329) 0c8ede0 Authored with Claude.
pytorchmergebot
pushed a commit
to scotts/pytorch
that referenced
this pull request
Apr 9, 2026
Includes the following commits: - remove the rocprofiler early exit hack (pytorch/kineto#1329) 0c8ede0 Authored with Claude.
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Apr 9, 2026
Includes the following commits: - remove the rocprofiler early exit hack (pytorch/kineto#1329) 0c8ede0 Authored with Claude. Pull Request resolved: #179579 Approved by: https://github.com/ryanzhang22
bobrenjc93
pushed a commit
to bobrenjc93/pytorch
that referenced
this pull request
Apr 10, 2026
Includes the following commits: * Expose occupany limiting factors (pytorch/kineto#1330) * remove the rocprofiler early exit hack (pytorch/kineto#1329) * Remove duplicate test ignore (pytorch/kineto#1328) * Ensure that async doesn't loop while sync is active (pytorch/kineto#1327) * Add host_name to OSS Kineto trace metadata via gethostname() (pytorch/kineto#1323) * Revert D97166802 (pytorch/kineto#1326) * Fix Lingering INT32 Overflow (pytorch/kineto#1324) * Re-enabled some hardcoded tests (pytorch/kineto#1321) * Expose occupany limiting factors (pytorch/kineto#1322) Authored with Claude. Pull Request resolved: pytorch#178918 Approved by: https://github.com/divyanshk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Remove the early exit hack because it seems to be doing more harm than good.
Differential Revision: D98163400