Skip to content

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Nov 13, 2025

Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn huydhn changed the title [no ci] Clean up Docker images on HPU and CPU benchmarks Clean up Docker images on HPU and CPU benchmarks Nov 13, 2025
@huydhn huydhn requested a review from yangw-dev November 13, 2025 22:29
uses: aws-actions/amazon-ecr-login@062b18b96a7aff071d4dc91bc00c4c1a7945b076 # v2.0.1
with:
registry-type: public

Copy link
Contributor

@yangw-dev yangw-dev Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why it is download in the first place, if those docker images are unused at this point? It just download all of them , and only use some? curious about this, but will approve

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are from previous jobs running on the same runner. This is a common issue for non-ephemeral runners where docker pull keeps piling up the images it uses over time. On our pet instances like H100, we have a daemon to clean up these images running on the server, so you don't see this step on CI. In this case, HPU servers are from Intel, so they are not set up in the same way

@huydhn huydhn merged commit 8dcdcda into main Nov 14, 2025
5 of 6 checks passed
@xuechendi
Copy link
Contributor

Thanks so much for the PR, I just acknowledged the issue this morning and cleaned up HPU now.
However, I found issue is not image not deleted(I have a cronjob to do so), but the docker container is never stopped after benchmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants