-
Notifications
You must be signed in to change notification settings - Fork 22
Several minor tweak to vllm benchmark workflow #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huy Do <huydhn@gmail.com>
043f5b1 to
c4dcf9f
Compare
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
yangw-dev
approved these changes
Dec 15, 2025
fadara01
added a commit
that referenced
this pull request
Dec 16, 2025
- re-enables the benchmarks disabled in #114 - related to vllm-project/vllm#26494 (not sure which needs to go in first) Signed-off-by: Fadi Arafeh <fadi.arafeh@arm.com>
fadara01
added a commit
that referenced
this pull request
Dec 16, 2025
- re-enables the benchmarks disabled in #114 - related to vllm-project/vllm#26494 (not sure which needs to go in first) - use default block_size in serving benchmarks (i.e. 128 instead of setting it to 16) Signed-off-by: Fadi Arafeh <fadi.arafeh@arm.com>
fadara01
added a commit
that referenced
this pull request
Dec 17, 2025
- re-enables the benchmarks disabled in #114 - related to vllm-project/vllm#26494 (not sure which needs to go in first) - use default block_size in serving benchmarks (i.e. 128 instead of setting it to 16) Signed-off-by: Fadi Arafeh <fadi.arafeh@arm.com>
fadara01
added a commit
that referenced
this pull request
Dec 17, 2025
- re-enables the benchmarks disabled in #114 - related to vllm-project/vllm#26494 (not sure which needs to go in first) - use default block_size in serving benchmarks (i.e. 128 instead of setting it to 16) Signed-off-by: Fadi Arafeh <fadi.arafeh@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several small tweaks:
servingbenchmark config. It always has all the models because serving benchmark is the most basic one, and it hastensor_parallel_sizefield set correctly. This is to fix a non deterministic issue where a model's tensor_parallel_size could be missing whenglobdecides to return the list of benchmark configs differently