Skip to content

Conversation

@namanlalitnyu
Copy link
Contributor

@namanlalitnyu namanlalitnyu commented Sep 28, 2025

Changes

After vllm-project/vllm#25786, the base directories for benchmarking are updated, so inorder to make sure the vLLM continuous benchmarking works as expected, we need to update the directories here as well.

Testing

Once the vLLM Changes are merged, we need to verify that vLLM Benchmark workflow is working as expected.

@meta-cla meta-cla bot added the cla signed label Sep 28, 2025
@huydhn huydhn changed the title [Draft] Update benchmark directory for vllm Update benchmark directory for vLLM Oct 30, 2025
@namanlalitnyu namanlalitnyu marked this pull request as ready for review October 30, 2025 20:24
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for the fix!

@huydhn huydhn merged commit e141125 into main Oct 31, 2025
43 of 54 checks passed
@huydhn huydhn deleted the fix_vllm_benchmarking branch November 3, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants