-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Closed
Closed
Copy link
Labels
high prioritymodule: compile uxUX issues related to torch.compileUX issues related to torch.compilemodule: dynamooncall: pt2topic: bug fixestopic categorytopic categorytriage reviewtriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Milestone
Description
This test fails since compilation succeeds when it should not, thus hiding a graph break.
def test_error_on_graph_break_nonempty_checkpoint(self):
cnts = torch._dynamo.testing.CompileCounter()
@torch.compile(backend=cnts)
def fn(x):
x = x + 1
x = x + 1
x = x + 1
with torch._dynamo.error_on_graph_break(True):
torch._dynamo.graph_break()
return x + 1
with self.assertRaises(Unsupported):
fn(torch.ones(3))
self.assertEqual(cnts.frame_count, 0)cc @ezyang @gchanan @kadeng @msaroufim @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @amjames @Lucaskabela
Metadata
Metadata
Assignees
Labels
high prioritymodule: compile uxUX issues related to torch.compileUX issues related to torch.compilemodule: dynamooncall: pt2topic: bug fixestopic categorytopic categorytriage reviewtriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module