Skip to content

clang-tidy job merges with master which can lead to hard to understand errors #25492

@ezyang

Description

@ezyang

All of the Azure jobs appear to run on /merge rather than the real commit, so they line up with ROCm behavior but not the rest of the behavior. Ordinarily I'd say this was bad... but it actually was good: in #24937 @pearu had a diff which would have caused a GEN_TO_SOURCE failure after merging with master, but the merge-with-master caught it. Except... it was really confusing and hard to tell what was going on, because the error referred to code that literally could not be found in the real copy. There should be some way to make it clearer what's going on here.

cc @ezyang

Metadata

Metadata

Assignees

No one assigned

    Labels

    module: ciRelated to continuous integrationtriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions