suppress -Wcast-function-type-strict when casting to PyCFunction
#100068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100068
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c680b75: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
dagitses
changed the title
-Wcast-function-type-strict when casting to PyCFunction-Wcast-function-type-strict when casting to PyCFunction
Summary: These casts are a necessary evil due to the design of Python. Python ultimately casts it back to the original type based on the flags specified in the `PyMethodDef`. Nevertheless, the new Clang flag `-Wcast-function-type-strict` breaks with this. While here, convert the cast to a `reinterpret_cast`. Test Plan: Should be a no-op. Rely on CI.
dagitses
changed the title
-Wcast-function-type-strict when casting to PyCFunction-Wcast-function-type-strict when casting to PyCFunction
dagitses
added
module: build warnings
Skylion007
approved these changes
Apr 26, 2023
|
@pytorchbot merge |
Skylion007
reviewed
Apr 26, 2023
| return (PyCFunction)(void (*)(void))func; | ||
| C10_DIAGNOSTIC_PUSH_AND_IGNORED_IF_DEFINED("-Wcast-function-type") | ||
| C10_DIAGNOSTIC_PUSH_AND_IGNORED_IF_DEFINED("-Wcast-function-type-strict") | ||
| return reinterpret_cast<PyCFunction>(func); |
There was a problem hiding this comment.
This cannot be a static_cast right?
There was a problem hiding this comment.
That's correct. The pointer types are unrelated and neither is void*.
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suppress
-Wcast-function-type-strictwhen casting to PyCFunctionSummary:
These casts are a necessary evil due to the design of Python. Python
ultimately casts it back to the original type based on the flags
specified in the
PyMethodDef.Nevertheless, the new Clang flag
-Wcast-function-type-strictbreakswith this.
While here, convert the cast to a
reinterpret_cast.Test Plan: Should be a no-op. Rely on CI.