[torch.library] Change Library.__del__ into weakref.finalize #101829
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`__del__` is a bit difficult to use, because when it is called, it is not guaranteed that anything it uses has not been cleaned up. Ed tells me he got the following exception one day, which is what prompted this PR. ``` Exception ignored in: <function Library.__del__ at 0x7fa36d211e50> Traceback (most recent call last): File "/data/users/ezyang/a/pytorch/torch/library.py", line 139, in __del__ AttributeError: 'NoneType' object has no attribute 'remove' ``` One solution is to use weakref.finalize, which lets one define a function to be run when the object is deleted that can hold references to specific things it needs. Another solution is to just check if the object is None, but I like the weakref solution better. Test Plan: - new test [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101829
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit d162f3a: NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zou3519
added a commit
that referenced
this pull request
May 18, 2023
`__del__` is a bit difficult to use, because when it is called, it is not guaranteed that anything it uses has not been cleaned up. Ed tells me he got the following exception one day, which is what prompted this PR. ``` Exception ignored in: <function Library.__del__ at 0x7fa36d211e50> Traceback (most recent call last): File "/data/users/ezyang/a/pytorch/torch/library.py", line 139, in __del__ AttributeError: 'NoneType' object has no attribute 'remove' ``` One solution is to use weakref.finalize, which lets one define a function to be run when the object is deleted that can hold references to specific things it needs. Another solution is to just check if the object is None, but I like the weakref solution better. Test Plan: - new test ghstack-source-id: 809ac42 Pull Request resolved: #101829
Skylion007
reviewed
May 19, 2023
ezyang
approved these changes
May 21, 2023
`__del__` is a bit difficult to use, because when it is called, it is not guaranteed that anything it uses has not been cleaned up. Ed tells me he got the following exception one day, which is what prompted this PR. ``` Exception ignored in: <function Library.__del__ at 0x7fa36d211e50> Traceback (most recent call last): File "/data/users/ezyang/a/pytorch/torch/library.py", line 139, in __del__ AttributeError: 'NoneType' object has no attribute 'remove' ``` One solution is to use weakref.finalize, which lets one define a function to be run when the object is deleted that can hold references to specific things it needs. Another solution is to just check if the object is None, but I like the weakref solution better. Test Plan: - new test [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
May 22, 2023
`__del__` is a bit difficult to use, because when it is called, it is not guaranteed that anything it uses has not been cleaned up. Ed tells me he got the following exception one day, which is what prompted this PR. ``` Exception ignored in: <function Library.__del__ at 0x7fa36d211e50> Traceback (most recent call last): File "/data/users/ezyang/a/pytorch/torch/library.py", line 139, in __del__ AttributeError: 'NoneType' object has no attribute 'remove' ``` One solution is to use weakref.finalize, which lets one define a function to be run when the object is deleted that can hold references to specific things it needs. Another solution is to just check if the object is None, but I like the weakref solution better. Test Plan: - new test ghstack-source-id: 7690b2f Pull Request resolved: #101829
Verified, and also added new tests to check that the refcounts are what we expect (and that there is no reference cycle as a result) |
zou3519
added
ciflow/trunk
|
@pytorchbot merge -f "distributed test timed out" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
__del__is a bit difficult to use, because when it is called, it isnot guaranteed that anything it uses has not been cleaned up.
Ed tells me he got the following exception one day, which is what
prompted this PR.
One solution is to use weakref.finalize, which lets one define a
function to be run when the object is deleted that can hold references
to specific things it needs.
Another solution is to just check if the object is None, but I like the
weakref solution better.
Test Plan: