Skip to content

[Reland2] fix missing-prototypes warnings in torch_cpu (Part 5) #102931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[Reland2] fix missing-prototypes warnings in torch_cpu (Part 5) #102931

wants to merge 6 commits into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Jun 4, 2023 •
edited by pytorch-bot bot
Loading

This PR relands the changes introduced in PR #101976 .

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

@pytorch-bot pytorch-bot bot added the release notes: linalg_frontend release notes category label Jun 4, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 4, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102931

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a210d20:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever marked this pull request as draft June 4, 2023 13:45
@github-actions github-actions bot added module: cpu CPU specific problem (e.g., perf, algorithm) release notes: quantization release notes category labels Jun 4, 2023
@cyyever cyyever changed the title [Reland] fix missing-prototypes warnings in torch_cpu (Part 5) [Reland2] fix missing-prototypes warnings in torch_cpu (Part 5) Jun 4, 2023
@cyyever cyyever marked this pull request as ready for review June 5, 2023 09:59
@Skylion007
Copy link
Collaborator

This PR relands the changes introduced in PR #102931 .

#102931 is this PR. I think you meant to copy a different PR number.

Skylion007
Skylion007 approved these changes Jun 9, 2023
View reviewed changes
Copy link
Collaborator

@Skylion007 Skylion007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this was reverted originally to revert an earlier commit. So it should be safe.

@Skylion007 Skylion007 closed this Jun 9, 2023
@Skylion007 Skylion007 reopened this Jun 9, 2023
@Skylion007 Skylion007 added the topic: not user facing topic category label Jun 9, 2023
@Skylion007
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 9, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase and merge by leaving the following comment on this PR:
@pytorchbot merge -r
Or just rebase by leaving @pytorchbot rebase comment

Details for Dev Infra team Raised by workflow job

@Skylion007
Copy link
Collaborator

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased missing_include5_reland2 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout missing_include5_reland2 && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the missing_include5_reland2 branch from f55a2d4 to a210d20 Compare June 9, 2023 18:51
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the missing_include5_reland2 branch August 6, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@lezcano lezcano Awaiting requested review from lezcano lezcano is a code owner

@nikitaved nikitaved Awaiting requested review from nikitaved nikitaved is a code owner

@IvanYashchuk IvanYashchuk Awaiting requested review from IvanYashchuk IvanYashchuk is a code owner

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168 jerryzh168 is a code owner

@salilsdesai salilsdesai Awaiting requested review from salilsdesai salilsdesai is a code owner

@kimishpatel kimishpatel Awaiting requested review from kimishpatel kimishpatel is a code owner

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

@jianyuh jianyuh Awaiting requested review from jianyuh jianyuh is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) open source release notes: linalg_frontend release notes category release notes: quantization release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cyyever @Skylion007 @pytorchmergebot @pytorchbot