[BE] Enable ruff's UP rules and autoformat optim/ #105426
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
justinchuby
requested review from
aaronenyeshi,
albanD and
janeyx99
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105426
Note: Links to docs will display an error until the docs builds have been completed. ✅ 1 Unrelated FailureAs of commit 7320a0c: UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: optimizer
This was referenced Jul 18, 2023
[ghstack-poisoned]
malfet
approved these changes
Jul 18, 2023
albanD
approved these changes
Jul 18, 2023
aaronenyeshi
approved these changes
Jul 18, 2023
janeyx99
approved these changes
Jul 18, 2023
| for size1, size2 in zip(reversed(mdbs), reversed(cdbs)): | ||
| if size1 != 1 and size2 != 1 and size1 != size2: | ||
| raise ValueError("`mixture_distribution.batch_shape` ({0}) is not " | ||
| raise ValueError("`mixture_distribution.batch_shape` ({}) is not " |
There was a problem hiding this comment.
why not use an fstring here?
| kc = self._component_distribution.batch_shape[-1] | ||
| if km is not None and kc is not None and km != kc: | ||
| raise ValueError("`mixture_distribution component` ({0}) does not" | ||
| raise ValueError("`mixture_distribution component` ({}) does not" |
There was a problem hiding this comment.
same as above for the other ValueErrors in this file
[ghstack-poisoned]
[ghstack-poisoned]
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Jul 18, 2023
ghstack-source-id: 3dcaa23 Pull Request resolved: pytorch#105426 Signed-off-by: Justin Chu <justinchu@microsoft.com>
|
@pytorchbot merge -f "rocm unstable" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
justinchuby
added
the
better-engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):