Skip to content

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Jul 18, 2023

Signed-off-by: Justin Chu <justinchu@microsoft.com>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 18, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105437

Note: Links to docs will display an error until the docs builds have been completed.

✅ 4 Unrelated Failures

As of commit d8932d0:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Signed-off-by: Justin Chu <justinchumicrosoft.com>

[ghstack-poisoned]
@huydhn
Copy link
Contributor

huydhn commented Jul 18, 2023

In the future, please consider breaking up this stack into multiple smaller ones of may be 2 to 3 depth each because this would very likely increase queue time on CI for scarce resources like ROCm, MacOS, or Windows. A stack of depth 15 means 15 times the regular number of CI jobs at once. As this has already started and the changes are lint-related, I would probably wait and cross my fingers that they all pass :)

cc @seemethere @malfet

@justinchuby
Copy link
Collaborator Author

In the future, please consider breaking up this stack into multiple smaller ones of may be 2 to 3 depth each because this would very likely increase queue time on CI for scarce resources like ROCm, MacOS, or Windows. A stack of depth 15 means 15 times the regular number of CI jobs at once. As this has already started and the changes are lint-related, I would probably wait and cross my fingers that they all pass :)

Sounds very reasonable. Thanks!

@justinchuby

This comment was marked as resolved.

Signed-off-by: Justin Chu <justinchumicrosoft.com>

[ghstack-poisoned]
Signed-off-by: Justin Chu <justinchumicrosoft.com>

[ghstack-poisoned]
@justinchuby justinchuby added the better-engineering Relatively self-contained tasks for better engineering contributors label Jul 19, 2023
Signed-off-by: Justin Chu <justinchumicrosoft.com>

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Jul 19, 2023
Signed-off-by: Justin Chu <justinchumicrosoft.com>

ghstack-source-id: 4969330
Pull Request resolved: pytorch#105437

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchumicrosoft.com>

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]
@justinchuby justinchuby added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 21, 2023
Signed-off-by: Justin Chu <justinchumicrosoft.com>

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]
Signed-off-by: Justin Chu <justinchumicrosoft.com>

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]
@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

Signed-off-by: Justin Chu <justinchumicrosoft.com>

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Jul 21, 2023
Signed-off-by: Justin Chu <justinchumicrosoft.com>

ghstack-source-id: cda9f31
Pull Request resolved: pytorch#105437

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchumicrosoft.com>

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Jul 21, 2023
Signed-off-by: Justin Chu <justinchumicrosoft.com>

ghstack-source-id: eeb6eb2
Pull Request resolved: pytorch#105437

Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/justinchuby/103/head branch July 25, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants