-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[BE] Enable ruff's UP rules in pyproject.toml #105437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Justin Chu <justinchu@microsoft.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105437
Note: Links to docs will display an error until the docs builds have been completed. ✅ 4 Unrelated FailuresAs of commit d8932d0: UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Signed-off-by: Justin Chu <justinchumicrosoft.com> [ghstack-poisoned]
|
In the future, please consider breaking up this stack into multiple smaller ones of may be 2 to 3 depth each because this would very likely increase queue time on CI for scarce resources like ROCm, MacOS, or Windows. A stack of depth 15 means 15 times the regular number of CI jobs at once. As this has already started and the changes are lint-related, I would probably wait and cross my fingers that they all pass :) |
Sounds very reasonable. Thanks! |
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Justin Chu <justinchumicrosoft.com> [ghstack-poisoned]
Signed-off-by: Justin Chu <justinchumicrosoft.com> [ghstack-poisoned]
Signed-off-by: Justin Chu <justinchumicrosoft.com> cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
Signed-off-by: Justin Chu <justinchumicrosoft.com> ghstack-source-id: 4969330 Pull Request resolved: pytorch#105437 Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchumicrosoft.com> cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
Signed-off-by: Justin Chu <justinchumicrosoft.com> cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
Signed-off-by: Justin Chu <justinchumicrosoft.com> cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
Signed-off-by: Justin Chu <justinchumicrosoft.com> cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
Signed-off-by: Justin Chu <justinchumicrosoft.com> ghstack-source-id: cda9f31 Pull Request resolved: pytorch#105437 Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchumicrosoft.com> cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
Signed-off-by: Justin Chu <justinchumicrosoft.com> ghstack-source-id: eeb6eb2 Pull Request resolved: pytorch#105437 Signed-off-by: Justin Chu <justinchu@microsoft.com>
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
Signed-off-by: Justin Chu justinchu@microsoft.com
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @ngimel @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov