Fixe some typos #105869

apivovarov · 2023-07-24T20:09:19Z

Description:

Fixes for typos in comments

pytorch-bot · 2023-07-24T20:09:21Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105869

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 6c6004b:

NEW FAILURE - The following job has failed:

linux-bionic-cuda12.1-py3.10-gcc9-sm86 / test (default, 1, 5, linux.g5.4xlarge.nvidia.gpu) (gh)

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

linux-focal-rocm5.6-py3.8 / test (default, 2, 3, linux.rocm.gpu, unstable) (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

linux-foundation-easycla · 2023-07-24T20:09:23Z

The committers listed above are authorized under a signed CLA.

✅ login: apivovarov / name: Alexander Pivovarov (6c6004b)

mikaylagawarecki

Thanks!

pytorchmergebot · 2023-07-24T21:00:21Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

mikaylagawarecki · 2023-07-24T21:20:16Z

torch/nn/modules/activation.py

-        return x.device.type in ["cpu", "cuda", torch.utils.backend_registration._privateuse1_backend_name]
-
-    return False
+    return x.device.type in ["cpu", "cuda", torch.utils.backend_registration._privateuse1_backend_name]


Actually, it seems like this was done on purpose see
#95653 (comment)

Cancelling the merge since this was done purposefully

I reverted python code fixes and left only typos fixes

pytorchmergebot · 2023-07-24T22:00:19Z

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

mikaylagawarecki · 2023-07-25T03:01:24Z

@pytorchbot merge

pytorchmergebot · 2023-07-25T03:04:17Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-07-25T07:02:04Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

pull / linux-bionic-cuda12.1-py3.10-gcc9-sm86 / test (default, 1, 5, linux.g5.4xlarge.nvidia.gpu)

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

Skylion007 · 2023-07-25T17:11:43Z

@pytorchbot merge -r

pytorchmergebot · 2023-07-25T17:14:17Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2023-07-25T17:14:22Z

Successfully rebased fix1 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix1 && git pull --rebase)

pytorchmergebot · 2023-07-25T17:15:30Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-07-25T20:57:52Z

Merge failed

Reason: Not merging any PRs at the moment because there is a merge blocking https://github.com/pytorch/pytorch/labels/ci:%20sev issue open at:
#105964

Details for Dev Infra team

Raised by workflow job

mikaylagawarecki · 2023-07-26T16:21:59Z

@pytorchbot merge -f "unrelated failures"

pytorchmergebot · 2023-07-26T16:23:50Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

apivovarov requested review from albanD, jbschlosser and mikaylagawarecki as code owners July 24, 2023 20:09

pytorchbot added the open source label Jul 24, 2023

mikaylagawarecki approved these changes Jul 24, 2023

View reviewed changes

mikaylagawarecki added the topic: not user facing topic category label Jul 24, 2023

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 24, 2023

pytorchmergebot added the merging label Jul 24, 2023

mikaylagawarecki reviewed Jul 24, 2023

View reviewed changes

apivovarov force-pushed the fix1 branch 2 times, most recently from 88743e5 to 0d84a7e Compare July 25, 2023 00:51

apivovarov changed the title ~~Fixes for dead code in nn/modules/activation.py~~ Fixes some typos Jul 25, 2023

apivovarov changed the title ~~Fixes some typos~~ Fixe some typos Jul 25, 2023

pytorchmergebot removed the merging label Jul 25, 2023

Skylion007 approved these changes Jul 25, 2023

View reviewed changes

Fix some typos

6c6004b

pytorchmergebot force-pushed the fix1 branch from 0d84a7e to 6c6004b Compare July 25, 2023 17:14

pytorchmergebot added the merging label Jul 25, 2023

pytorchmergebot removed the merging label Jul 25, 2023

mikaylagawarecki mentioned this pull request Jul 26, 2023

Simplify check #106044

Closed

pytorchmergebot added the merging label Jul 26, 2023

pytorchmergebot added Merged and removed merging labels Jul 26, 2023

pytorchmergebot closed this in 28a4fc8 Jul 26, 2023

Fixe some typos #105869

Fixe some typos #105869

Uh oh!

Conversation

apivovarov commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Uh oh!

pytorch-bot bot commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105869

❌ 1 New Failure, 1 Unrelated Failure

Uh oh!

linux-foundation-easycla bot commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mikaylagawarecki left a comment

Choose a reason for hiding this comment

Uh oh!

pytorchmergebot commented Jul 24, 2023

Merge started

Uh oh!

mikaylagawarecki Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

mikaylagawarecki Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

apivovarov Jul 25, 2023

Choose a reason for hiding this comment

Uh oh!

pytorchmergebot commented Jul 24, 2023

Uh oh!

mikaylagawarecki commented Jul 25, 2023

Uh oh!

pytorchmergebot commented Jul 25, 2023

Merge started

Uh oh!

pytorchmergebot commented Jul 25, 2023

Merge failed

Uh oh!

Skylion007 commented Jul 25, 2023

Uh oh!

pytorchmergebot commented Jul 25, 2023

Uh oh!

pytorchmergebot commented Jul 25, 2023

Uh oh!

pytorchmergebot commented Jul 25, 2023

Merge started

Uh oh!

pytorchmergebot commented Jul 25, 2023

Merge failed

Uh oh!

mikaylagawarecki commented Jul 26, 2023

Uh oh!

pytorchmergebot commented Jul 26, 2023

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

apivovarov commented Jul 24, 2023 •

edited

Loading

pytorch-bot bot commented Jul 24, 2023 •

edited

Loading

linux-foundation-easycla bot commented Jul 24, 2023 •

edited

Loading