[pt2] add meta for cholesky
#106115
Closed
[pt2] add meta for cholesky
#106115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106115
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4a9ec7d: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
nkaretnikov
added
ciflow/trunk
|
From the list in #105105. Note: it's a deprecated op, so can be potentially removed, but I've just added a meta to avoid getting sidetracked. |
nkaretnikov
commented
Jul 27, 2023
| squareCheckInputs(self, "cholesky") | ||
| return cloneBatchedColumnMajor(self) | ||
|
|
||
|
|
There was a problem hiding this comment.
See cholesky in aten/src/ATen/native/BatchLinearAlgebra.cpp
[ghstack-poisoned]
nkaretnikov
requested review from
Chillee,
ezyang,
mruberry and
ngimel
as code owners
Skylion007
approved these changes
Jul 27, 2023
ezyang
approved these changes
Jul 27, 2023
[ghstack-poisoned]
bobby-palmer
pushed a commit
to bobby-palmer/pytorch
that referenced
this pull request
Jul 29, 2023
Pull Request resolved: pytorch#106115 Approved by: https://github.com/Skylion007, https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
cholesky_inverse#106120cholesky#106115