Skip to content

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Aug 9, 2023

Stack from ghstack (oldest at bottom):

🤖 Generated by Copilot at 54e843d

Float8 types added
to switch on ScalarType -
CUDA version checked.

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 9, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106843

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 54e843d:

NEW FAILURE - The following job has failed:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vkuzo
Copy link
Contributor

vkuzo commented Aug 9, 2023

to clarify, does this bind the unsaturated casts?

@vkuzo
Copy link
Contributor

vkuzo commented Aug 9, 2023

i.e. if someone does torch.randn(4, 4).cuda().to(torch.float8_e4m3fn), will the casts be hardware accelerated or go through the bit shifting path?

@malfet malfet changed the title Add Float8 data-type conversion Add F8 BLAS data types conversion Aug 9, 2023
@malfet
Copy link
Contributor Author

malfet commented Aug 9, 2023

to clarify, does this bind the unsaturated casts?

No, this is a no-op that simple adds BLAS dtypes, let me change the title to clarify what it does a bit better.

Wow, CoPilot did a really great job of summarizing the change.

@malfet
Copy link
Contributor Author

malfet commented Aug 9, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 9, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@malfet malfet added the topic: not user facing topic category label Aug 9, 2023
@malfet
Copy link
Contributor Author

malfet commented Aug 9, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 3, 3, windows.4xlarge.nonephemeral)

Details for Dev Infra team Raised by workflow job

@malfet
Copy link
Contributor Author

malfet commented Aug 9, 2023

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 3 checks: trunk / linux-focal-rocm5.6-py3.8 / test (default, 1, 3, linux.rocm.gpu, unstable), trunk / linux-focal-rocm5.6-py3.8 / test (default, 3, 3, linux.rocm.gpu, unstable), trunk / win-vs2019-cpu-py3 / test (default, 3, 3, windows.4xlarge.nonephemeral)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Aug 9, 2023
Pull Request resolved: #106842
Approved by: https://github.com/vkuzo
ghstack dependencies: #106843
@facebook-github-bot facebook-github-bot deleted the gh/malfet/51/head branch August 13, 2023 14:17
Cyril-Anto pushed a commit to Cyril-Anto/pytorch that referenced this pull request Aug 17, 2023
<!--
copilot:poem
-->
### <samp>🤖 Generated by Copilot at 54e843d</samp>

> _`Float8` types added_
> _to switch on `ScalarType` -_
> _CUDA version checked._
Pull Request resolved: pytorch#106843
Approved by: https://github.com/Skylion007
Cyril-Anto pushed a commit to Cyril-Anto/pytorch that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants